Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cc rust-lang/compiler for toolstate changes #65276

Merged
merged 1 commit into from
Oct 12, 2019
Merged

Don't cc rust-lang/compiler for toolstate changes #65276

merged 1 commit into from
Oct 12, 2019

Conversation

varkor
Copy link
Member

@varkor varkor commented Oct 10, 2019

Fixes #65238.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2019
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=always

Per agreement on the issue. I don't think we need an FCP for this change (but if others disagree, feel free to unapprove and start FCP).

@bors
Copy link
Contributor

bors commented Oct 10, 2019

📌 Commit fb392c5 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 11, 2019
@tmandry
Rollup merge of rust-lang#65276 - varkor:toolstate-no-ping, r=Mark-Si…
f1d2d95 
…mulacrum

Don't cc rust-lang/compiler for toolstate changes

Fixes rust-lang#65238.
@tmandry tmandry mentioned this pull request Oct 11, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Oct 11, 2019
@tmandry
Rollup merge of rust-lang#65276 - varkor:toolstate-no-ping, r=Mark-Si…
7ed57bb 
…mulacrum

Don't cc rust-lang/compiler for toolstate changes

Fixes rust-lang#65238.
tmandry added a commit to tmandry/rust that referenced this pull request Oct 11, 2019
@tmandry
Rollup merge of rust-lang#65297 - tmandry:rollup-pe7a2i2, r=tmandry
c7c6cbf 
Rollup of 16 pull requests

Successful merges:

 - rust-lang#64337 (libstd: Fix typos in doc)
 - rust-lang#64986 (Function pointers as const generic arguments)
 - rust-lang#65048 (Added doc about behavior of extend on HashMap)
 - rust-lang#65191 (Add some regression tests)
 - rust-lang#65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation)
 - rust-lang#65205 (Add long error explanation for E0568)
 - rust-lang#65240 (self-profiling: Add events for metadata loading (plus a small dep-tracking optimization))
 - rust-lang#65248 (Suggest `if let` on `let` refutable binding)
 - rust-lang#65252 (expand: Simplify expansion of derives)
 - rust-lang#65263 (Deduplicate is_{freeze,copy,sized}_raw)
 - rust-lang#65265 (Cleanup librustc mir err codes)
 - rust-lang#65266 (Mark Path::join as must_use)
 - rust-lang#65276 (Don't cc rust-lang/compiler for toolstate changes)
 - rust-lang#65277 (Query generator kind for error reporting)
 - rust-lang#65283 (stability: Do not use `buffer_lint` after lowering to HIR)
 - rust-lang#65289 (Fix suggested bound addition diagnostic)

Failed merges:

r? @ghost
@tmandry tmandry mentioned this pull request Oct 11, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Oct 11, 2019
@Centril
Rollup merge of rust-lang#65276 - varkor:toolstate-no-ping, r=Mark-Si…
d1f1cfd 
…mulacrum

Don't cc rust-lang/compiler for toolstate changes

Fixes rust-lang#65238.
@Centril Centril mentioned this pull request Oct 11, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Oct 11, 2019
@Centril
Rollup merge of rust-lang#65299 - tmandry:rollup-pe7a2i2, r=tmandry
ebc1d34 
Rollup of 16 pull requests

Successful merges:

 - rust-lang#64337 (libstd: Fix typos in doc)
 - rust-lang#64986 (Function pointers as const generic arguments)
 - rust-lang#65048 (Added doc about behavior of extend on HashMap)
 - rust-lang#65191 (Add some regression tests)
 - rust-lang#65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation)
 - rust-lang#65205 (Add long error explanation for E0568)
 - rust-lang#65240 (self-profiling: Add events for metadata loading (plus a small dep-tracking optimization))
 - rust-lang#65248 (Suggest `if let` on `let` refutable binding)
 - rust-lang#65252 (expand: Simplify expansion of derives)
 - rust-lang#65263 (Deduplicate is_{freeze,copy,sized}_raw)
 - rust-lang#65265 (Cleanup librustc mir err codes)
 - rust-lang#65266 (Mark Path::join as must_use)
 - rust-lang#65276 (Don't cc rust-lang/compiler for toolstate changes)
 - rust-lang#65277 (Query generator kind for error reporting)
 - rust-lang#65283 (stability: Do not use `buffer_lint` after lowering to HIR)
 - rust-lang#65289 (Fix suggested bound addition diagnostic)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Oct 11, 2019
@bors
Auto merge of #65301 - Centril:rollup-e0mglu4, r=Centril
8533a5e 
Rollup of 11 pull requests

Successful merges:

 - #64337 (libstd: Fix typos in doc)
 - #65048 (Added doc about behavior of extend on HashMap)
 - #65191 (Add some regression tests)
 - #65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation)
 - #65205 (Add long error explanation for E0568)
 - #65263 (Deduplicate is_{freeze,copy,sized}_raw)
 - #65266 (Mark Path::join as must_use)
 - #65276 (Don't cc rust-lang/compiler for toolstate changes)
 - #65277 (Query generator kind for error reporting)
 - #65283 (stability: Do not use `buffer_lint` after lowering to HIR)
 - #65299 (Rollup of 16 pull requests)

Failed merges:

r? @ghost
tmandry added a commit to tmandry/rust that referenced this pull request Oct 11, 2019
@tmandry
Rollup merge of rust-lang#65276 - varkor:toolstate-no-ping, r=Mark-Si…
9917f06 
…mulacrum

Don't cc rust-lang/compiler for toolstate changes

Fixes rust-lang#65238.
@tmandry tmandry mentioned this pull request Oct 11, 2019
Merged
bors added a commit that referenced this pull request Oct 12, 2019
@bors
Auto merge of #65322 - tmandry:rollup-frr651r, r=tmandry
026447b 
Rollup of 15 pull requests

Successful merges:

 - #64337 (libstd: Fix typos in doc)
 - #64986 (Function pointers as const generic arguments)
 - #65048 (Added doc about behavior of extend on HashMap)
 - #65191 (Add some regression tests)
 - #65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation)
 - #65205 (Add long error explanation for E0568)
 - #65220 (Update LLVM for Emscripten exception handling support)
 - #65263 (Deduplicate is_{freeze,copy,sized}_raw)
 - #65266 (Mark Path::join as must_use)
 - #65276 (Don't cc rust-lang/compiler for toolstate changes)
 - #65277 (Query generator kind for error reporting)
 - #65283 (stability: Do not use `buffer_lint` after lowering to HIR)
 - #65289 (Fix suggested bound addition diagnostic)
 - #65310 (deriving: avoid dummy Span on an artificial `type_ident` path)
 - #65321 (Remove painful test that is not pulling its weight)

Failed merges:

r? @ghost
@bors bors merged commit fb392c5 into rust-lang:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't cc rust-lang/compiler for toolstate changes
5 participants
@varkor @rust-highfive @Mark-Simulacrum @bors @nikomatsakis